Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mails styling reset password #1651

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Conversation

adititipnis
Copy link
Contributor

@adititipnis adititipnis commented Jan 16, 2024

image

Copy link
Contributor

@JijoBose JijoBose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock icon missing from the mailer,

Screenshot 2024-01-19 at 2 12 16 PM

JijoBose
JijoBose previously approved these changes Jan 19, 2024
Copy link
Contributor

@JijoBose JijoBose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-19 at 2 19 12 PM

@JijoBose JijoBose requested a review from nisusam January 29, 2024 11:06
font-weight: 400;
font-size: 14px;
line-height: 19px;
text-align: center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate.
Fix Indentation.

Copy link
Contributor

@nisusam nisusam Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file if unused. Also please use filenames without spaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file if unused. Also please use filenames without spaces.

@JijoBose JijoBose dismissed their stale review February 16, 2024 06:31

change required

@apoorv1316
Copy link
Contributor

@adititipnis Please work on review comments

font-weight: 400;
font-size: 14px;
line-height: 19px;
text-align: center;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is duplicate.

color: #FFFFFF;
text-decoration: none;
display: inline-block;
display: flex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

display property used couple of times

Copy link
Contributor

@nisusam nisusam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the comments. Rest LGTM!

@adititipnis adititipnis merged commit f5143d2 into develop Mar 5, 2024
1 check passed
@adititipnis adititipnis deleted the mails-styling-reset-password branch March 5, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants