Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign team list page #1673

Merged
merged 13 commits into from
Mar 6, 2024
Merged

Redesign team list page #1673

merged 13 commits into from
Mar 6, 2024

Conversation

Shruti-Apte
Copy link
Contributor

@Shruti-Apte Shruti-Apte commented Feb 27, 2024

What:

Redesign team list page

Preview:
Screenshot 2024-02-27 at 4 32 58 PM

Screenshot 2024-02-27 at 4 33 16 PM

@Shruti-Apte Shruti-Apte marked this pull request as ready for review February 27, 2024 12:38
Copy link
Contributor

@nisusam nisusam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and also fix rubocop offense

@Shruti-Apte Shruti-Apte requested a review from nisusam March 1, 2024 07:18
Copy link
Contributor

@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please work on the requested changes

const start = new Date(joinedAt);
const today = new Date();

const daysDifference = differenceInCalendarDays(today, start);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please use intervalToDuration instead of differenceInCalendarDays?
https://date-fns.org/v2.16.1/docs/intervalToDuration

@Shruti-Apte Shruti-Apte requested a review from nisusam March 6, 2024 06:21
Copy link
Contributor

@nisusam nisusam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix & Ship!

@Shruti-Apte Shruti-Apte merged commit 69fe1d8 into develop Mar 6, 2024
1 check passed
@Shruti-Apte Shruti-Apte deleted the redesign_team_list_page branch March 6, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants