Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validations for state, city and pin #1676

Closed
wants to merge 2 commits into from

Conversation

adititipnis
Copy link
Contributor

No description provided.

@apoorv1316
Copy link
Contributor

apoorv1316 commented Feb 29, 2024

@adititipnis The issue which user reported still exists. How does removing validations fixes this issue? We can allow free text with the validations and we can either remove the dropdown or keep it while allowing the user to enter anything they want.

@adititipnis
Copy link
Contributor Author

adititipnis commented Mar 1, 2024

@adititipnis The issue which user reported still exists. How does removing validations fixes this issue? We can allow free text with the validations and we can either remove the dropdown or keep it while allowing the user to enter anything they want.

@apoorv1316 I am able to add a client with the details provided in the issue. The validations were blocking the client from being added since "city" was a required field which we cannot populate for Hampshire because of the limitations of the package. Such limitations exist for a few more states and cities so it makes sense to get rid of the validations to unblock similar scenarios. The only issue that remains is the 'undefined' response from the backend. This can be handled on the frontend but it would be more appropriate to receive an undefined type from the backend rather than a string as seen below.
image
image

@adititipnis
Copy link
Contributor Author

As confirmed with @sonamvg , a textbox will be shown instead of the dropdown when options for the dropdown are not available

@vipulnsward
Copy link
Contributor

  • Do not keep drop downs for anything except country, don't complicate logic here to show textbox or dropdown
  • Add validation that street address is mandatory
  • Do not remove existing validations

@vipulnsward vipulnsward deleted the 1595-allow-blank-city branch March 14, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants