Export options for accounts aging #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorv1316
force-pushed
the
export-reports-accounts-aging
branch
from
a49aae5
to
47edb5e
Compare
nisusam
requested changes
Mar 6, 2024
app/services/reports/generate_csv.rb
Outdated
|
|
||
| data.each do |row| | ||
| csv << row | ||
| end |
nisusam
requested changes
Mar 8, 2024
app/services/reports/generate_pdf.rb
Outdated
| locals: { report_data:, current_company: } | ||
| ).make | ||
| end | ||
| def generate_time_entries_pdf |
There was a problem hiding this comment.
You can create common method for both the reports def generate_pdf_reports(reports)
nisusam
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
@apoorv1316 The total amount is without currency in CSV Data. Please update the same in the new PR.
Rest LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Preview
https://www.loom.com/share/7bb851c20a7047c38523b0192bd064ec