Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark time off responsive #1710

Merged
merged 8 commits into from
Mar 15, 2024
Merged

Mark time off responsive #1710

merged 8 commits into from
Mar 15, 2024

Conversation

prasanthchaduvula
Copy link
Contributor

What

  • Added mark time off feature on mobile with add, update, delete and duplicate operations.
  • Fixed the leave date error on duplication of time off entry on the web.
  • Fixed the work date error on duplication of timesheet entry on the web and mobile.
  • Created EntryButton components and refactored the timesheet codebase.
  • Updated the button component size styles so that we can override them with classnames.
  • Refactored the maritime off forms and moved the complete logic into one component and only rendered forms in other components.

Figma

https://www.figma.com/file/4gdPDRPqGqQqPYsO3Qj8CG/Miru-App?type=design&node-id=18953-141908&mode=design&t=RGTox1yJchcY1siY-0

Demo

https://youtu.be/chHU2C-WTP8?feature=shared

@prasanthchaduvula prasanthchaduvula merged commit 982e77f into develop Mar 15, 2024
1 check passed
@prasanthchaduvula prasanthchaduvula deleted the mark-time-off-responsive branch March 15, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisusam nisusam nisusam approved these changes

@apoorv1316 apoorv1316 Awaiting requested review from apoorv1316

Assignees

@nisusam nisusam

@apoorv1316 apoorv1316

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prasanthchaduvula @nisusam @apoorv1316