Refresh page after adding/editing team member #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasanthchaduvula
requested changes
Mar 26, 2024
| @@ -53,6 +55,12 @@ const TeamList = () => { | |||
| getTeamList(); | |||
| }, []); | |||
|
|
|||
| useEffect(() => { | |||
| if (refreshList) { | |||
| getTeamList(); | |||
There was a problem hiding this comment.
Instead of fetching again, either use the updated response from the create, update or delete requests with the previous state or update the API response with the updated list.
prasanthchaduvula
requested changes
Mar 26, 2024
| @@ -72,13 +72,17 @@ const EditClient = ({ user = {}, isEdit = false }: Props) => { | |||
| if (isEdit) { | |||
| if (user.isTeamMember) { | |||
| await teamApi.updateTeamMember(user.id, payload); | |||
| setRefreshList(true); | |||
| } else { | ||
| await teamApi.deleteInvitedMember(user.id); | ||
| setRefreshList(true); |
merge with develop
added 2 commits
April 9, 2024 10:28
|
@prasanthchaduvula Please review again |
prasanthchaduvula
requested changes
Apr 10, 2024
| } else { | ||
| await teamApi.updateInvitedMember(user.id, payload); | ||
| const res = await teamApi.updateInvitedMember(user.id, payload); | ||
| const updatedUser = res.data.invitation; |
There was a problem hiding this comment.
Create updatedTeamList function. Extract the below logic and call it inside the above if and this else conditions and pass theres.data.useror res.data.invitation as param.
teamList.map(member => {
if (member.id === updatedUser.id) {
return updatedUser;
}
return member;
});
setTeamList(updatedTeamList);
| } else { | ||
| await teamApi.deleteInvitedMember(user.id); | ||
| const res = await teamApi.deleteInvitedMember(user.id); | ||
| const updatedTeamList = teamList.filter( |
There was a problem hiding this comment.
create one function named updatedTeamListAferDelete with below code and pass res.data.user.id or res.data.id and call it inside the if and else conditions
teamList.filter(
member => member.id !== id
);
setTeamList(updatedTeamList);
added 2 commits
April 10, 2024 10:23
prasanthchaduvula
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1741
What