Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get total duration group by filters #1780

Merged
merged 7 commits into from
Apr 9, 2024
Merged

Conversation

apoorv1316
Copy link
Contributor

Closes #1746

@apoorv1316 apoorv1316 requested a review from nisusam April 3, 2024 07:38

joins_clause, group_field = case group_by
when :client
[[:project, :client], "clients.id"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this

id_field = GROUP_BY_INPUT_TO_GROUP_ID_FIELD[group_by.to_s]

grouped_data = es_response.group_by { |entry| entry[label_field] }.map do |label, entries|
id = entries.first[id_field]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation

@apoorv1316 apoorv1316 merged commit 42de04f into develop Apr 9, 2024
1 check passed
@apoorv1316 apoorv1316 deleted the time-enntry-group-duration branch April 9, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time entry total should remain consistent throughout on reports page
2 participants