Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holiday calendar added #1810

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Holiday calendar added #1810

merged 5 commits into from
Apr 29, 2024

Conversation

Shruti-Apte
Copy link
Contributor

closes #1796

@apoorv1316
Copy link
Contributor

The holiday calendar is showing the date on which user applied for the holiday and not the actual holiday date. So, if republic holiday is on 26 January but the user added the holiday entry for it on 10th April then the calendar will show the 10th April as holiday and if the user has not applied for that holiday then that holiday won't shown in the calendar.
@Shruti-Apte @sonamvg @prasanthchaduvula

@Shruti-Apte
Copy link
Contributor Author

Shruti-Apte commented Apr 22, 2024

@apoorv1316
According to me, To make sure users always select the correct holiday date, we can auto-populate the date field based on the selected holiday. i.e 26 jan for republic day should be auto-populated and must be a non-editable field on time off entries

cc: @sonamvg @prasanthchaduvula

@sonamvg
Copy link
Contributor

sonamvg commented Apr 23, 2024

The calendar should show a list as per holidays updated by the Org admin as reflected in settings page.
This is to address the concern of showing list of holidays and optional holidays to employee.

@apoorv1316 apoorv1316 merged commit 816c9cc into develop Apr 29, 2024
1 check passed
@apoorv1316 apoorv1316 deleted the view_holiday_calendar branch April 29, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add calendar icon on leaves page to show list of holidays
4 participants