Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for OpenVSX #10

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Conversation

dscottboggs
Copy link
Contributor

This PR makes #9 obsolete, and additionally removes the unnecessary dependency on ms-vscode.cpptools (see discussion in #8), making the extension ready for publishing to both the official Microsoft extension repository as well as the OpenVSX repository.

@dscottboggs dscottboggs force-pushed the fix/prepare-for-openvsx branch from 726a4bd to 38cd4a2 Compare October 17, 2020 20:52
@saem saem mentioned this pull request Oct 18, 2020
Copy link
Owner

@saem saem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of the dependency is the only blocker.

Optionally, changelog entry would be appreciated (please credit yourself) but not necessary.

@dscottboggs dscottboggs force-pushed the fix/prepare-for-openvsx branch from 2f6ca10 to 65aa1ed Compare October 19, 2020 04:45
@dscottboggs dscottboggs requested a review from saem October 19, 2020 04:46
@saem saem merged commit c5fb7eb into saem:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants