use generic Go facilities to get a socket #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safchain
reviewed
Mar 8, 2018
| fd, _, err := syscall.RawSyscall(syscall.SYS_SOCKET, syscall.AF_INET, syscall.SOCK_DGRAM, syscall.IPPROTO_IP) | ||
| if err != 0 { | ||
| return nil, syscall.Errno(err) | ||
| fd, err := syscall.Socket(syscall.AF_INET, syscall.SOCK_DGRAM, syscall.IPPROTO_IP) |
There was a problem hiding this comment.
Hi, I used low level syscall in order to limit the impact of the Go bug with namespaces see golang/go#20676
As it is fixed in 1.10 I think that OK now.
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
May 13, 2019
Fail build on x86: github.com/safchain/ethtool/ethtool.go:205:35: undefined: syscall.SYS_SOCKET Applied patch as described here: safchain/ethtool#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
syscall.Socketinstead of the more low-levelRawSyscallinterface to obtain a socket descriptor. The former approach also works on i386, while the latter does not. See #15.Closes #15.