Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.0 Fixes #310

Merged
merged 2 commits into from
Nov 27, 2018
Merged

Version 1.0.0 Fixes #310

merged 2 commits into from
Nov 27, 2018

Conversation

rmeissner
Copy link
Member

Changes proposed in this pull request:

  • Fix crash because of vector drawable
  • Enable recovery phrase intro screen
  • Scroll to next word in recovery phrase confirm screen

@gnosis/mobile-devs

…reen; Scroll to next word in recovery phrase confirm screen
@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #310 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #310      +/-   ##
============================================
- Coverage     40.28%   40.18%   -0.11%     
  Complexity      492      492              
============================================
  Files           223      223              
  Lines          6268     6284      +16     
  Branches        901      903       +2     
============================================
  Hits           2525     2525              
- Misses         3489     3505      +16     
  Partials        254      254
Impacted Files Coverage Δ Complexity Δ
.../ui/recoveryphrase/ConfirmRecoveryPhraseAdapter.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ui/recoveryphrase/ConfirmRecoveryPhraseActivity.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...m/gnosis/heimdall/ui/safe/main/SafeMainActivity.kt 32.65% <0%> (ø) 17 <0> (ø) ⬇️
...pm/gnosis/heimdall/ui/safe/main/NoSafesFragment.kt 61.53% <0%> (ø) 4 <0> (ø) ⬇️
...l/ui/recoveryphrase/SetupRecoveryPhraseActivity.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...l/ui/recoveryphrase/RecoveryPhraseIntroActivity.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...l/ui/safe/recover/safe/RecoverSafeIntroActivity.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e486a07...91f3fdf. Read the comment docs.

@rmeissner rmeissner merged commit 550704f into master Nov 27, 2018
@rmeissner rmeissner deleted the fix_kitkat_crash branch November 27, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants