Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #365: Adjust transfer screen #383

Merged
merged 6 commits into from
Jun 6, 2019
Merged

Closes #365: Adjust transfer screen #383

merged 6 commits into from
Jun 6, 2019

Conversation

rmeissner
Copy link
Member

Closes #365.

Changes proposed in this pull request:

  • Changed design of transfer screen
  • Added "Balance after transfer" to multiple screens

@gnosis/mobile-devs

@rmeissner rmeissner self-assigned this Jun 4, 2019
@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

Merging #383 into master will increase coverage by 0.12%.
The diff coverage is 40.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #383      +/-   ##
============================================
+ Coverage     34.16%   34.28%   +0.12%     
- Complexity      455      457       +2     
============================================
  Files           249      249              
  Lines          7464     7531      +67     
  Branches       1062     1079      +17     
============================================
+ Hits           2550     2582      +32     
- Misses         4672     4701      +29     
- Partials        242      248       +6
Impacted Files Coverage Δ Complexity Δ
...s/view/viewholders/GenericTransactionViewHolder.kt 87.09% <0%> (-2.91%) 12 <0> (ø)
...ecover/safe/submit/RecoveringSafeSubmitFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ecover/extension/ReplaceExtensionSubmitActivity.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...iew/viewholders/ReplaceRecoveryPhraseViewHolder.kt 93.33% <0%> (-6.67%) 8 <0> (ø)
...ons/view/viewholders/ConnectExtensionViewHolder.kt 96% <0%> (-4%) 8 <0> (ø)
.../recover/safe/submit/RecoveringSafeFundFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...imdall/ui/safe/pending/SafeCreationFundFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/pm/gnosis/heimdall/helpers/AddressInputHelper.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...transactions/create/CreateAssetTransferActivity.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...afe/recover/safe/submit/RecoveringSafeViewModel.kt 96.46% <100%> (+0.92%) 12 <0> (ø) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d79a625...543eb66. Read the comment docs.

@rmeissner rmeissner merged commit 9ccebe0 into master Jun 6, 2019
@rmeissner rmeissner deleted the feature/issue_365 branch June 6, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust design of transfer screen
3 participants