Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI session closed when using a derivation path with "" or '' with Trezor hardware wallet #343

Closed
JagoFigueroa opened this issue Jan 17, 2024 · 2 comments · Fixed by #414
Assignees
Labels
bug Something isn't working

Comments

@JagoFigueroa
Copy link

Describe the bug
Small issue where the CLI will crash when either "" or '' are used when trying to load an address from a derivation path on Trezor.

To Reproduce
Example command:

load_trezor_cli_owners --legacy-accounts --derivation-path "44'/60'/0'/0"

Expected behavior
Return an error, same as with ledger:

load_ledger_cli_owners --legacy-accounts --derivation-path "44'/60'/0'/0"
HwDevice exception: The provided derivation path is not valid

Current behaviour
The CLI crashes

@JagoFigueroa JagoFigueroa added the bug Something isn't working label Jan 17, 2024
@JagoFigueroa JagoFigueroa changed the title CLI crashing when using a derivation path with "" or '' with Trezor hardware wallet CLI session closed when using a derivation path with "" or '' with Trezor hardware wallet Jan 17, 2024
@moisses89
Copy link
Member

The CLI is not crashing but I'm still adding support for double quoting because looks like the natural behavior of an user.
#414

@JagoFigueroa
Copy link
Author

Working like a charm, thank you caballero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants