Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for double quotation mark derivation path #414

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Add support for double quotation mark derivation path #414

merged 2 commits into from
Jun 14, 2024

Conversation

moisses89
Copy link
Member

Closes #343

@moisses89 moisses89 requested a review from a team as a code owner June 14, 2024 11:45
@moisses89 moisses89 mentioned this pull request Jun 14, 2024
Closed
@coveralls
Copy link

Coverage Status

coverage: 87.033%. remained the same
when pulling df0de80 on fix_quoted_derivation
into bebbba2 on main.

@coveralls
Copy link

Coverage Status

coverage: 87.033%. remained the same
when pulling 9fd7f90 on fix_quoted_derivation
into bebbba2 on main.

Uxio0
Uxio0 approved these changes Jun 14, 2024
View reviewed changes
src/safe_cli/operators/hw_wallets/hw_wallet.py Outdated Show resolved Hide resolved
@moisses89 moisses89 merged commit 4235146 into main Jun 14, 2024
13 checks passed
@moisses89 moisses89 deleted the fix_quoted_derivation branch June 14, 2024 14:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI session closed when using a derivation path with "" or '' with Trezor hardware wallet
3 participants
@moisses89 @coveralls @Uxio0