Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hw_wallet overwrites previous signatures #411

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix hw_wallet overwrites previous signatures #411

merged 1 commit into from
Jun 12, 2024

Conversation

moisses89
Copy link
Member

Description

sign_safe_tx of HwWalletManager was removing previous signatures in the SafeTx.

Solution

Concatenate previous signatures and export the sorted signatures.

@moisses89 moisses89 self-assigned this Jun 12, 2024
@moisses89 moisses89 requested a review from a team as a code owner June 12, 2024 10:43
@coveralls
Copy link

Coverage Status

coverage: 87.136% (-0.02%) from 87.16%
when pulling 78bec1e on fix_overwrite_signature
into cc5b9f1 on main.

@moisses89 moisses89 merged commit 29be0a2 into main Jun 12, 2024
14 checks passed
@moisses89 moisses89 deleted the fix_overwrite_signature branch June 12, 2024 11:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@falvaradorodriguez falvaradorodriguez falvaradorodriguez approved these changes

Assignees

@moisses89 moisses89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moisses89 @coveralls @falvaradorodriguez