Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message confirmation #418

Merged
merged 7 commits into from
Jun 20, 2024
Merged

Add message confirmation #418

merged 7 commits into from
Jun 20, 2024

Conversation

moisses89
Copy link
Member

@moisses89 moisses89 commented Jun 18, 2024

Description

Adds confirm_message for tx-service mode.
This new command let the user add confirmation for a created message in the transaction service.

Closes #346

Other changes

  • sign_message for EIP191 is receiving now the message to sign as input instead of parameter, previous implementation had issues with quotes and blank spaces, also this new approach let the user paste longer messages.
  • refactor submit signatures to reuse the function sign_transaction, cleaning at this way duplicated code.

@coveralls
Copy link

Coverage Status

coverage: 86.772% (-0.2%) from 86.934%
when pulling 949e84f on add_message_confirmation
into 88ca917 on main.

@coveralls
Copy link

Coverage Status

coverage: 87.279% (+0.3%) from 86.934%
when pulling e1c6100 on add_message_confirmation
into 88ca917 on main.

@moisses89 moisses89 marked this pull request as ready for review June 19, 2024 07:47
@moisses89 moisses89 requested a review from a team as a code owner June 19, 2024 07:47
@coveralls
Copy link

Coverage Status

coverage: 87.279% (+0.3%) from 86.934%
when pulling 53e6bff on add_message_confirmation
into 88ca917 on main.

@coveralls
Copy link

Coverage Status

coverage: 87.279% (+0.3%) from 86.934%
when pulling b8b048e on add_message_confirmation
into 88ca917 on main.

@coveralls
Copy link

Coverage Status

coverage: 87.279% (+0.3%) from 86.934%
when pulling 734f8d5 on add_message_confirmation
into 88ca917 on main.

@coveralls
Copy link

Coverage Status

coverage: 87.279% (+0.3%) from 86.934%
when pulling 64bcea1 on add_message_confirmation
into 88ca917 on main.

@coveralls
Copy link

Coverage Status

coverage: 87.279% (+0.3%) from 86.934%
when pulling 0e4d426 on add_message_confirmation
into 88ca917 on main.

@moisses89 moisses89 merged commit dbea553 into main Jun 20, 2024
14 checks passed
@moisses89 moisses89 deleted the add_message_confirmation branch June 20, 2024 12:10
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support add message confirmation on transaction service mode
3 participants