Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hw wallet sign message #420

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Add hw wallet sign message #420

merged 3 commits into from
Jun 27, 2024

Conversation

moisses89
Copy link
Member

@moisses89 moisses89 commented Jun 20, 2024

Description

Add support to sign messages using hardware wallet on transaction service mode.
Close #354

Other changes

@coveralls
Copy link

Coverage Status

coverage: 87.131% (+0.2%) from 86.934%
when pulling 6670730 on add_hw_wallet_sign_message
into 88ca917 on main.

@moisses89 moisses89 marked this pull request as ready for review June 27, 2024 11:54
@moisses89 moisses89 requested a review from a team as a code owner June 27, 2024 11:54
@coveralls
Copy link

Coverage Status

coverage: 87.559% (+0.09%) from 87.47%
when pulling 3bcfc8f on add_hw_wallet_sign_message
into ddd66d6 on main.

@coveralls
Copy link

Coverage Status

coverage: 87.559% (+0.09%) from 87.47%
when pulling 909e0f1 on add_hw_wallet_sign_message
into ddd66d6 on main.

@coveralls
Copy link

Coverage Status

coverage: 88.571% (+0.07%) from 88.505%
when pulling a12b5e1 on add_hw_wallet_sign_message
into e829cd6 on main.

Copy link
Contributor

@falvaradorodriguez falvaradorodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the source code are fine for me. In any case I validate it based on the tests (I can't test it without HW wallet).

@moisses89 moisses89 merged commit 01de249 into main Jun 27, 2024
14 checks passed
@moisses89 moisses89 deleted the add_hw_wallet_sign_message branch June 27, 2024 14:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sign message to hardware manager class
3 participants