Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly declare hexbytes dependency #421

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

fmrsabino
Copy link
Contributor

We are using hexbytes as a dependency in our argparse_validators however the dependency is only available transitively.

The following describes how hexbytes is provided:

hexbytes==0.3.1
├── eth-account==0.11.2 [requires: hexbytes>=0.1.0,<0.4.0]
│   └── web3==6.19.0 [requires: eth-account>=0.8.0,<0.13]
│       └── safe-eth-py==6.0.0b30 [requires: web3>=6.2.0]
│           └── safe-cli==1.2.1 [requires: safe-eth-py==6.0.0b30]
├── eth-rlp==1.0.1 [requires: hexbytes>=0.1.0,<1]
│   └── eth-account==0.11.2 [requires: eth-rlp>=0.3.0]
│       └── web3==6.19.0 [requires: eth-account>=0.8.0,<0.13]
│           └── safe-eth-py==6.0.0b30 [requires: web3>=6.2.0]
│               └── safe-cli==1.2.1 [requires: safe-eth-py==6.0.0b30]
├── trie==3.0.1 [requires: hexbytes>=0.2.3]
│   └── py-evm==0.10.1b1 [requires: trie>=2.0.0]
│       └── safe-eth-py==6.0.0b30 [requires: py-evm>=0.7.0a1]
│           └── safe-cli==1.2.1 [requires: safe-eth-py==6.0.0b30]
└── web3==6.19.0 [requires: hexbytes>=0.1.0,<0.4.0]
    └── safe-eth-py==6.0.0b30 [requires: web3>=6.2.0]
        └── safe-cli==1.2.1 [requires: safe-eth-py==6.0.0b30]

We should declare hexbytes as a project dependency in case any of the dependencies that include stop using and exporting it.

@fmrsabino fmrsabino self-assigned this Jun 24, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner June 24, 2024 13:13
@coveralls
Copy link

Coverage Status

coverage: 87.279%. remained the same
when pulling 480381a on declare-hexbytes-dependency
into dbea553 on main.

Copy link
Member

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmrsabino
Copy link
Contributor Author

@fmrsabino Remember to add the dependency here: https://github.com/safe-global/safe-cli/blob/main/pyproject.toml

Good catch 👍 I've set the range of >=0.2.3,<0.4.0. Let me know what you think (the trie dependency requires at least version 0.2.3)

177056d

@fmrsabino fmrsabino requested a review from Uxio0 June 25, 2024 13:54
@coveralls
Copy link

Coverage Status

coverage: 87.279%. remained the same
when pulling 177056d on declare-hexbytes-dependency
into dbea553 on main.

@fmrsabino fmrsabino merged commit a9427b2 into main Jun 25, 2024
14 checks passed
@fmrsabino fmrsabino deleted the declare-hexbytes-dependency branch June 25, 2024 15:05
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants