Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove variable shadowing #422

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Remove variable shadowing #422

merged 1 commit into from
Jun 25, 2024

Conversation

fmrsabino
Copy link
Contributor

Removes the variable shadowing with i – this variable is already being used for the outer loop.

While not being used in the inner loop, we should rename it/remove it to avoid potential issues where the variable might be referenced in the future.

@fmrsabino fmrsabino self-assigned this Jun 24, 2024
@fmrsabino fmrsabino requested a review from a team as a code owner June 24, 2024 13:46
@coveralls
Copy link

Coverage Status

coverage: 87.279%. remained the same
when pulling de34301 on remove-var-shadowing
into dbea553 on main.

@fmrsabino fmrsabino merged commit d9ac0c1 into main Jun 25, 2024
14 checks passed
@fmrsabino fmrsabino deleted the remove-var-shadowing branch June 25, 2024 12:09
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants