Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exception with invalid contract method name in tx-builder #429

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

falvaradorodriguez
Copy link
Contributor

@falvaradorodriguez falvaradorodriguez commented Jun 28, 2024

Related with #36
Problem detected in QA validation.

When the method we are trying to encode is not valid, we are throwing an exception. This is an error, following the front-end tx-builder steps here should return a None.

@falvaradorodriguez falvaradorodriguez requested a review from a team as a code owner June 28, 2024 08:44
@coveralls
Copy link

Coverage Status

coverage: 88.58% (+0.009%) from 88.571%
when pulling 45609cd on fix_tx_builder_decoder
into f343bb8 on main.

Copy link
Contributor

@fmrsabino fmrsabino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@falvaradorodriguez falvaradorodriguez merged commit d59dc92 into main Jun 28, 2024
14 checks passed
@falvaradorodriguez falvaradorodriguez deleted the fix_tx_builder_decoder branch June 28, 2024 09:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
@falvaradorodriguez falvaradorodriguez restored the fix_tx_builder_decoder branch July 1, 2024 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants