Make CreationTransaction['saltNonce'] nullable (#2054)

Adjusts the expected value of `saltNonce` to be `string | null`.
safe-global · Oct 24, 2024 · 85e2d8b · 85e2d8b
1 parent fc2bdec
commit 85e2d8b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/src/domain/safe/entities/schemas/__tests__/creation-transaction.schema.spec.ts b/src/domain/safe/entities/schemas/__tests__/creation-transaction.schema.spec.ts
@@ -48,6 +48,7 @@ describe('CreationTransactionSchema', () => {
     'masterCopy' as const,
     'setupData' as const,
     'dataDecoded' as const,
+    'saltNonce' as const,
   ])('should allow an optional %s', (field) => {
     const creationTransaction = creationTransactionBuilder().build();
     delete creationTransaction[field];
@@ -101,7 +102,6 @@ describe('CreationTransactionSchema', () => {
     'creator' as const,
     'transactionHash' as const,
     'factoryAddress' as const,
-    'saltNonce' as const,
   ])('should not allow an undefined %s', (field) => {
     const creationTransaction = creationTransactionBuilder().build();
     delete creationTransaction[field];

diff --git a/src/domain/safe/entities/schemas/creation-transaction.schema.ts b/src/domain/safe/entities/schemas/creation-transaction.schema.ts
@@ -10,6 +10,6 @@ export const CreationTransactionSchema = z.object({
   factoryAddress: AddressSchema,
   masterCopy: AddressSchema.nullish().default(null),
   setupData: HexSchema.nullish().default(null),
-  saltNonce: z.string(),
+  saltNonce: z.string().nullish().default(null),
   dataDecoded: DataDecodedSchema.nullish().default(null),
 });
diff --git a/src/routes/transactions/entities/creation-transaction-info.entity.ts b/src/routes/transactions/entities/creation-transaction-info.entity.ts
@@ -14,15 +14,15 @@ export class CreationTransactionInfo extends TransactionInfo {
   implementation: AddressInfo | null;
   @ApiPropertyOptional({ type: AddressInfo, nullable: true })
   factory: AddressInfo | null;
-  @ApiProperty()
-  saltNonce: string;
+  @ApiPropertyOptional({ type: String, nullable: true })
+  saltNonce: string | null;
 
   constructor(
     creator: AddressInfo,
     transactionHash: string,
     implementation: AddressInfo | null,
     factory: AddressInfo | null,
-    saltNonce: string,
+    saltNonce: string | null,
   ) {
     super(TransactionInfoType.Creation, null, null);
     this.creator = creator;

diff --git a/src/routes/transactions/entities/creation-transaction.entity.ts b/src/routes/transactions/entities/creation-transaction.entity.ts
@@ -15,8 +15,8 @@ export class CreationTransaction implements DomainCreationTransaction {
   masterCopy: `0x${string}` | null;
   @ApiPropertyOptional({ type: String, nullable: true })
   setupData: `0x${string}` | null;
-  @ApiProperty()
-  saltNonce: string;
+  @ApiPropertyOptional({ type: String, nullable: true })
+  saltNonce: string | null;
   @ApiPropertyOptional({ type: DataDecoded, nullable: true })
   dataDecoded: DataDecoded | null;
 
@@ -27,7 +27,7 @@ export class CreationTransaction implements DomainCreationTransaction {
     factoryAddress: `0x${string}`,
     masterCopy: `0x${string}` | null,
     setupData: `0x${string}` | null,
-    saltNonce: string,
+    saltNonce: string | null,
     dataDecoded: DataDecoded | null,
   ) {
     this.created = created;