Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decoding for TWAP orders #1649

Closed
iamacook opened this issue Jun 13, 2024 · 0 comments · Fixed by #1669
Closed

Add decoding for TWAP orders #1649

iamacook opened this issue Jun 13, 2024 · 0 comments · Fixed by #1669
Assignees

Comments

@iamacook
Copy link
Member

iamacook commented Jun 13, 2024

Description

To facilitate the TWAP-relevant designs, we need to add decoding of TWAP orders. These can either be a multiSend call enabling the Fallback Handler and creating an order with the ComposableCoW contract (createWithContext) or just creating an order createWithContext.

Note: we believe we can decode the createWithContext parameters to get the required information (it calls ethers' decodeFunctionData). (We may need to make an API call to determine the fulfilment percentage.)

Requirements

  • Ascertain the required fields for the design
  • Determine the sources of the aforementioned
  • Map the fields into (batched) transactions to the relevant contract, calling createWithContext

Additional information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant