Add base decoder for ComposableCoW contract #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9548973981Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9548972969Details
💛 - Coveralls |
iamacook
commented
Jun 18, 2024
| }); | ||
| }); | ||
|
|
||
| it.todo('should throw if TWAP handler is invalid'); |
There was a problem hiding this comment.
I will come back and add this coverage as it involves understanding of complex encoding.
Pull Request Test Coverage Report for Build 9561299550Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9562233686Details
💛 - Coveralls |
hectorgomezv
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of #1649, we need to return extra swap information for TWAP decoding, e.g. the start time, number of parts, time between parts and duration of part.
This adds a new
ComposableCowDecoder, based on the required elements of the CoW SDK to detect and decodecreateWithContextcalls. The reason for creating our own decoder is to reduce dependency reliance: the SDK has a peer dependency of ethers for example (which we don't use).Changes
ComposableCowDecoder