Check INFURA_API_KEY value at startup #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacook
approved these changes
Jun 12, 2024
hectorgomezv
commented
Jun 12, 2024
| @@ -59,6 +59,7 @@ export class BlockchainApiManager implements IBlockchainApiManager { | |||
| }; | |||
| } | |||
|
|
|||
| // Note: this assumes Infura as provider when using an API key as authentication method. | |||
There was a problem hiding this comment.
Let me know if you think this note is redundant @iamacook, but I think we have to be aware that if a Chain is configured with a different RPC provider, this function will try to use INFURA_API_KEY with the other provider URL, right?
There was a problem hiding this comment.
It will but I think it's fine. It's the same implementation as the Web.
We could alternatively check that the value contains "infura" in it. What do you think?
There was a problem hiding this comment.
I'm totally OK with checking the URL, will do it separately 👍🏻
Pull Request Test Coverage Report for Build 9479245935Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
INFURA_API_KEYto the sample.envfile.INFURA_API_KEYtodocker-compose.ymlfile.INFURA_API_KEYto the startup environment validator.