Limit maximum amount of TWAP parts

[iamacook]

Summary

There can be up to uint256 parts in a TWAP order meaning that we would current request information about each from CoW when mapping.

This limits the number of parts we request up to 11 (confirmed by CoW) - which can be configured by an env. var. (swaps.maxNumberOfParts). If there are >11 parts, the final one is used to fetch the status and token information but it means that executedSellAmount and executedBuyAmount are null as we cannot calculate them.

Changes

• Add swaps.maxNumberOfParts configuration
• Update TwapOrderInfo['executedSellAmount' | 'executedBuyAmount'] to be string | null
• Limit number of parts, fetching only the last if more than the maximum
• Add appropriate test coverage

[coveralls]

Pull Request Test Coverage Report for Build 9566781013

Details

• 5 of 10 (50.0%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.04%) to 49.253%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/routes/transactions/mappers/common/twap-order.mapper.ts	3	8	37.5%

Files with Coverage Reduction	New Missed Lines	%
src/routes/transactions/mappers/common/twap-order.mapper.ts	1	28.77%

Totals
Change from base Build 9566099283:	-0.04%
Covered Lines:	4071
Relevant Lines:	6663

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9568383771

Details

• 5 of 10 (50.0%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.04%) to 49.231%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/routes/transactions/mappers/common/twap-order.mapper.ts	3	8	37.5%

Files with Coverage Reduction	New Missed Lines	%
src/routes/transactions/mappers/common/twap-order.mapper.ts	1	28.77%

Totals
Change from base Build 9568377389:	-0.04%
Covered Lines:	4071
Relevant Lines:	6665

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9578727585

Details

• 5 of 10 (50.0%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.04%) to 49.231%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/routes/transactions/mappers/common/twap-order.mapper.ts	3	8	37.5%

Files with Coverage Reduction	New Missed Lines	%
src/routes/transactions/mappers/common/twap-order.mapper.ts	1	28.77%

Totals
Change from base Build 9578682874:	-0.04%
Covered Lines:	4071
Relevant Lines:	6665

---

💛 - Coveralls

[hectorgomezv]

Nit: what do you think about renaming _parts to twapOrderParts (or orderParts, allParts, etc.) instead of using a _ prefix? I think it might be more readable.

[iamacook]

Agreed. I renamed the former to twapParts and then parts to partsToFetch for clarity in a2e114f.

[coveralls]

Pull Request Test Coverage Report for Build 9580178858

Details

• 5 of 11 (45.45%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.04%) to 49.231%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/routes/transactions/mappers/common/twap-order.mapper.ts	3	9	33.33%

Files with Coverage Reduction	New Missed Lines	%
src/routes/transactions/mappers/common/twap-order.mapper.ts	1	28.77%

Totals
Change from base Build 9578682874:	-0.04%
Covered Lines:	4071
Relevant Lines:	6665

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9581748889

Details

• 5 of 11 (45.45%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.001%) to 49.275%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/routes/transactions/mappers/common/twap-order.mapper.ts	3	9	33.33%

Files with Coverage Reduction	New Missed Lines	%
src/routes/transactions/mappers/common/twap-order.mapper.ts	1	28.77%

Totals
Change from base Build 9579639391:	0.001%
Covered Lines:	4073
Relevant Lines:	6665

---

💛 - Coveralls