Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map TWAP orders in the queue #1683

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Map TWAP orders in the queue #1683

merged 2 commits into from
Jun 24, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jun 24, 2024

Summary

We currently check that an executionDate is present within a transaction in order to map the TWAP order. However, queued transactions aren't executed yet.

This removes the above check, adjusting the logic accordingly so that TWAP orders inthe queue can be mapped.

Changes

  • Decouple fetching of buy/sell token with order, fetching the later separately
  • Don't fetch orders if the transaction is not executed, mapping "empty" values if no orders were fetched
  • Add/update the test coverage accordingly

@iamacook iamacook requested a review from a team as a code owner June 24, 2024 11:49
@iamacook iamacook merged commit 5037b6c into main Jun 24, 2024
16 checks passed
@iamacook iamacook deleted the twap-queue branch June 24, 2024 12:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9644786118

Details

  • 0 of 13 (0.0%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.005%) to 48.739%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/mappers/common/transaction-info.mapper.ts 0 1 0.0%
src/routes/transactions/mappers/common/swap-order.mapper.ts 0 2 0.0%
src/routes/transactions/transactions-view.service.ts 0 2 0.0%
src/routes/transactions/mappers/common/twap-order.mapper.ts 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/helpers/swap-order.helper.ts 1 27.27%
src/routes/transactions/transactions-view.service.ts 1 17.14%
src/routes/transactions/mappers/common/swap-order.mapper.ts 1 25.58%
src/routes/transactions/mappers/common/twap-order.mapper.ts 1 32.81%
Totals Coverage Status
Change from base Build 9642573892: 0.005%
Covered Lines: 4107
Relevant Lines: 6799

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9644865960

Details

  • 0 of 13 (0.0%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.03%) to 48.707%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/mappers/common/transaction-info.mapper.ts 0 1 0.0%
src/routes/transactions/mappers/common/swap-order.mapper.ts 0 2 0.0%
src/routes/transactions/transactions-view.service.ts 0 2 0.0%
src/routes/transactions/mappers/common/twap-order.mapper.ts 0 8 0.0%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/helpers/swap-order.helper.ts 1 27.27%
src/routes/transactions/transactions-view.service.ts 1 17.14%
src/routes/transactions/mappers/common/swap-order.mapper.ts 1 25.58%
src/routes/transactions/mappers/common/twap-order.mapper.ts 1 30.0%
Totals Coverage Status
Change from base Build 9642573892: -0.03%
Covered Lines: 4107
Relevant Lines: 6799

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants