Include SwapTransfer
when checking whether TransactionInfo['type']
is a transfer
#1725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When mapping swap transfers, the
type
is no longerTransfer
butSwapTransfer
. This means that any comparisons happening according to what was previouslyTransfer
no longer happen: trust filtering and imitation flagging early returns.This adds the relative checks for
SwapTransfer
-typed transfers, as well as adding relative test coverage.Changes
Note: the following can be assumed as we check the address of the settlement contract:
trust
when filtering transfers