Extract swap app allowance into helper #1738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Swap decoded is restricted to certain allowed apps. Now that we are decoding swap orders/transfers and TWAP orders, this check occurs in several places. There are dedicated
isAppAllowed
methods for both swap and TWAPs.This extracts the multiple methods in a new
SwapApps
helper, calling it in every places instead.Changes
SwapAppsHelper
isAppAllowed
with that from the above helper