Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AccountDataType.dataTypeId to AccountDataType.id #1751

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Rename AccountDataType.dataTypeId to AccountDataType.id #1751

merged 1 commit into from
Jul 10, 2024

Conversation

hectorgomezv
Copy link
Member

Summary

Aiming to be consistent with the decisions taken in this discussion #1715 (comment), this PR changes dataTypeId to id in the route layer entity AccountDataType.

Changes

  • Rename AccountDataType.dataTypeId to AccountDataType.id.

@hectorgomezv hectorgomezv requested a review from a team as a code owner July 10, 2024 14:18
@hectorgomezv hectorgomezv self-assigned this Jul 10, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9875935909

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 48.165%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/accounts/entities/account-data-type.entity.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 9858819355: 0.04%
Covered Lines: 4246
Relevant Lines: 7078
💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 2ce4ac8 into main Jul 10, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the rename-account-data-type-id branch July 10, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamacook iamacook iamacook approved these changes

Assignees

@hectorgomezv hectorgomezv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hectorgomezv @coveralls @iamacook