Add DB_MAX_SAFE_INTEGER constant #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10114076917Details
💛 - Coveralls |
iamacook
reviewed
Jul 26, 2024
| @@ -0,0 +1,5 @@ | |||
| /** | |||
| * The maximum safe integer for the database. | |||
| * This is the maximum value that can be stored in the database for an integer column. | |||
There was a problem hiding this comment.
Nit: can we add a link to a reference for this?
iamacook
approved these changes
Jul 26, 2024
DenSmolonski
pushed a commit
to Zilliqa/safe-client-gateway
that referenced
this pull request
Oct 24, 2024
Add DB_MAX_SAFE_INTEGER constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Context: #1773 (comment)
Changes
DB_MAX_SAFE_INTEGERconstant, with value(2^31)-1(max Postgres value for anintegercolumn).