Set AUTH_VALIDITY_PERIOD_SECONDS as access token default validity #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10322088723Details
💛 - Coveralls |
iamacook
approved these changes
Aug 12, 2024
DenSmolonski
pushed a commit
to Zilliqa/safe-client-gateway
that referenced
this pull request
Oct 24, 2024
…bal#1817) Modifies auth. service to take the value `AUTH_VALIDITY_PERIOD_SECONDS` from the configuration as a default value for the `exp` attribute of the issued JWTs (and also the `maxAge`) value for the auth cookies: - Takes `AUTH_VALIDITY_PERIOD_SECONDS` as the default value when not specified by the client on the SiWE message. - Increases the default for this value to 24 hours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the service to take the value
AUTH_VALIDITY_PERIOD_SECONDSfrom the configuration as a default value for theexpattribute of the issued JWTs (and also themaxAge) value for the auth cookies.Changes
AUTH_VALIDITY_PERIOD_SECONDSas the default value when not specified by the client on the SiWE message.