Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annual/monthly rewards calculation #1862

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

hectorgomezv
Copy link
Member

Closes #1860

Summary

This PR adds a calculation for getting both expectedMonthlyRewards and expectedAnnualRewards values in the Confirmation View transaction screen for native staking.

Changes

  • Add expectedMonthlyRewards and expectedAnnualRewards in wei to Native Staking Transaction Confirmation View.

@hectorgomezv hectorgomezv self-assigned this Aug 27, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner August 27, 2024 11:16
@hectorgomezv hectorgomezv linked an issue Aug 27, 2024 that may be closed by this pull request
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10577046468

Details

  • 2 of 5 (40.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.007%) to 46.761%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/transactions-view.service.ts 0 1 0.0%
src/routes/transactions/entities/staking/native-staking-confirmation-view.entity.ts 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/transactions-view.service.ts 1 16.04%
src/routes/transactions/entities/staking/native-staking-confirmation-view.entity.ts 1 60.61%
Totals Coverage Status
Change from base Build 10576372801: -0.007%
Covered Lines: 4752
Relevant Lines: 8219

💛 - Coveralls

@hectorgomezv hectorgomezv merged commit a0aef80 into main Aug 27, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the add-native-staking-expected-rewards branch August 27, 2024 13:11
DenSmolonski pushed a commit to Zilliqa/safe-client-gateway that referenced this pull request Oct 24, 2024
Add expectedMonthlyRewards and expectedAnnualRewards in wei to Native Staking Transaction Confirmation View
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Native Staking annual/monthly expected rewards
2 participants