Add value/numValidators for ValidatorsExit transactions mappings #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10639604127Details
💛 - Coveralls |
iamacook
reviewed
Sep 2, 2024
Comment on lines
+235
to
+250
| private getValueFromDataDecoded(data: DataDecoded, chain: Chain): number { | ||
| if (data.method === 'requestValidatorsExit') { | ||
| const publicKeys = | ||
| data.parameters?.filter( | ||
| (parameter) => parameter.name === '_publicKeys', | ||
| ) ?? []; | ||
| const decimals = chain.nativeCurrency.decimals; | ||
| return ( | ||
| publicKeys.length * | ||
| Math.pow(10, decimals) * | ||
| NativeStakingMapper.ETH_ETHERS_PER_VALIDATOR | ||
| ); | ||
| } | ||
|
|
||
| return 0; | ||
| } |
There was a problem hiding this comment.
Nit: we should add a comment/test for this as it's very intricate.
There was a problem hiding this comment.
I've included some documentation here: #1884
Please let me know if you find it's not clear enough. Thanks!
DenSmolonski
pushed a commit
to Zilliqa/safe-client-gateway
that referenced
this pull request
Oct 24, 2024
…e-global#1880) Adds `value` and `numValidators` calculations based on the transaction data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds missing fields to transaction mappings for the history/queue of Native Staking Validators Exit transactions.
Changes
valueandnumValidatorscalculations based on the transaction data.