Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Promise.all in NativeStakingMapper #1883

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Use Promise.all in NativeStakingMapper #1883

merged 1 commit into from
Sep 3, 2024

Conversation

hectorgomezv
Copy link
Member

Changes

  • Optimizes NativeStakingMapper by using Promise.all to parallelize API calls.

@hectorgomezv hectorgomezv self-assigned this Sep 2, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner September 2, 2024 15:49
@hectorgomezv hectorgomezv mentioned this pull request Sep 2, 2024
Merged
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10670082352

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 46.335%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/routes/transactions/mappers/common/native-staking.mapper.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 10639751772: 0.008%
Covered Lines: 4811
Relevant Lines: 8361
💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 56262ee into main Sep 3, 2024
18 checks passed
@hectorgomezv hectorgomezv deleted the native-staking-mapper-optimization branch September 3, 2024 13:30
DenSmolonski pushed a commit to Zilliqa/safe-client-gateway that referenced this pull request Oct 24, 2024
@hectorgomezv @DenSmolonski
Use Promise.all in NativeStakingMapper (safe-global#1883)
8b4dd65 
Optimizes NativeStakingMapper by using Promise.all to parallelize API calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamacook iamacook iamacook approved these changes

Assignees

@hectorgomezv hectorgomezv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hectorgomezv @coveralls @iamacook