-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage reports configuration #1892
Conversation
04cd9f5
to
d722fdf
Compare
Pull Request Test Coverage Report for Build 10684918840Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coverage report still shows 46%. Do we first need to merge it?
You're right, I was under the impression that including the This is the change: 9de1100 It's less clear, but works. Another idea would be to just restrict the coverage analysis to |
As it's not touched often, I don't think the clarity is a huge concern. I'm still not seeing an updated coverage report though 🙈 |
I think Coveralls is not updating the report for some reason, but I see in this branch only And in other branches also other folders (like (See the |
Adds non-relevant test coverage folders to coveragePathIgnorePatterns configuration.
Summary
Since the
rootDir
change in this PR, the coverage reports are taking into consideration all the folders in the root, instead of/src
only. This PR restores this behavior by ignoring non-relevant folders regarding test coverage.Changes
coveragePathIgnorePatterns
configuration.