Revert "Remove fallback for Kiln's unverified contracts (#1919)" #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a85dee8.
Pull Request Test Coverage Report for Build 10845223386Details
💛 - Coveralls |
hectorgomezv
approved these changes
Sep 13, 2024
PooyaRaki
approved these changes
Sep 13, 2024
DenSmolonski
pushed a commit
to Zilliqa/safe-client-gateway
that referenced
this pull request
Oct 24, 2024
…1919)" (safe-global#1922) This reverts commit a85dee8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The fallback value for the unverified contracts was previously removed as we were informed that all were verified. However,
0xf448e20F8a69aeb88a7dFB837e6aFaB5E7bCF80ehas yet to be. This resulted in a404error being returned on the confirmation endpoint.This reverts the offending commit.
Note: a follow up PR will look into moving the fallback values to where transactions are "found" to simplify the process and not require usage of the endpoint in question.
Changes