Refactor cache clearing logic into EventCacheHelper
#1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10937273807Details
💛 - Coveralls |
PooyaRaki
reviewed
Sep 18, 2024
PooyaRaki
reviewed
Sep 18, 2024
PooyaRaki
reviewed
Sep 18, 2024
PooyaRaki
approved these changes
Sep 19, 2024
This reverts commit 847c1aa.
DenSmolonski
pushed a commit
to Zilliqa/safe-client-gateway
that referenced
this pull request
Oct 24, 2024
Adds a new `EventCacheHelper`, breaking down respective event logic into a separate method. It is then used in both the (non-)event based hook repositories: - Extract cache-related logic to `EventCacheHelper` - Use `EventCacheHelper` in `HooksRepository` and `HooksRepositoryWithNotifications` - Update tests accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1926
Our
HooksRepository['onEventClearCache']covers cache clearing based on every event from the Transaction Service and Config. Service and is therefore excessively long. Considering we also have a similar class for notification-enabled hooks, this logic was duplicated.This adds a new
EventCacheHelper, breaking down respective event logic into a separate method. It is then used in both the (non-)event based hook repositories.Changes
EventCacheHelperEventCacheHelperinHooksRepositoryandHooksRepositoryWithNotifications