Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all Kiln-related encoding to kiln-encoder.builder #1959

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Conversation

iamacook
Copy link
Member

Summary

In order to test our KilnDecoder we encode both function/event data for specific methods. All other decoders have defined encoders. Currently, only the event-specific encoding is located within one for Kiln.

This moves all function-specific data encoding to the Kiln-specific encoder.

Changes

  • Create encoders for deposit, requestValidatorsExit and batchWithdrawCLFee.
  • Cleanup DepositEvent encoder implementation.
  • Use above encoders in relative tests.

@iamacook iamacook self-assigned this Sep 25, 2024
@coveralls
Copy link

coveralls commented Sep 25, 2024

Pull Request Test Coverage Report for Build 11032937275

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.775%

Totals Coverage Status
Change from base Build 11032628216: 0.0%
Covered Lines: 8371
Relevant Lines: 8848

💛 - Coveralls

Base automatically changed from deposit-status to main September 25, 2024 12:05
@iamacook iamacook marked this pull request as ready for review September 25, 2024 12:07
@iamacook iamacook requested a review from a team as a code owner September 25, 2024 12:07
@iamacook iamacook merged commit 894cb3b into main Sep 25, 2024
18 checks passed
@iamacook iamacook deleted the kiln-encoder branch September 25, 2024 15:16
DenSmolonski pushed a commit to Zilliqa/safe-client-gateway that referenced this pull request Oct 24, 2024
…#1959)

Moves all function-specific data encoding to the Kiln-specific encoder:

- Create encoders for `deposit`, `requestValidatorsExit` and `batchWithdrawCLFee`.
- Cleanup `DepositEvent` encoder implementation.
- Use above encoders in relative tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants