Return validator addresses in staking entities #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11054300850Details
💛 - Coveralls |
Comment on lines
+628
to
+639
| const validators = [ | ||
| faker.string.hexadecimal({ | ||
| length: KilnDecoder.KilnPublicKeyLength, | ||
| // Transaction Service returns _publicKeys lowercase | ||
| casing: 'lower', | ||
| }), | ||
| faker.string.hexadecimal({ | ||
| length: KilnDecoder.KilnPublicKeyLength, | ||
| casing: 'lower', | ||
| }), | ||
| ] as Array<`0x${string}`>; | ||
| const validatorPublicKey = concat(validators); |
There was a problem hiding this comment.
Nit: validators is not being expected in the response, I think it would be better to include it:
expect(actual).toEqual(
expect.objectContaining({
type: 'NativeStakingWithdraw',
value: withdrawalEventParams.rewards.toString(),
tokenInfo: {
address: NULL_ADDRESS,
decimals: chain.nativeCurrency.decimals,
logoUri: chain.nativeCurrency.logoUri,
name: chain.nativeCurrency.name,
symbol: chain.nativeCurrency.symbol,
trusted: true,
},
validators,
}),
);
Comment on lines
+546
to
+557
| const validators = [ | ||
| faker.string.hexadecimal({ | ||
| length: KilnDecoder.KilnPublicKeyLength, | ||
| // Transaction Service returns _publicKeys lowercase | ||
| casing: 'lower', | ||
| }), | ||
| faker.string.hexadecimal({ | ||
| length: KilnDecoder.KilnPublicKeyLength, | ||
| casing: 'lower', | ||
| }), | ||
| ] as Array<`0x${string}`>; | ||
| const validatorPublicKey = concat(validators); |
There was a problem hiding this comment.
Nit: same here, validators is not being checked in the test.
hectorgomezv
approved these changes
Sep 26, 2024
hectorgomezv
approved these changes
Sep 26, 2024
DenSmolonski
pushed a commit
to Zilliqa/safe-client-gateway
that referenced
this pull request
Oct 24, 2024
Returns the validators under a new `validators` property for all staking entities (apart from pre-executed deposits): - Add `validators` property to: - Confirmation view: exit requests and withdrawals - Transaction info: deposits (after execution), exit requests and withdrawals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As it is not possible to always return the current value for exit requests, we will not show the number of validators exiting in the transaction list of the UI. For individual validators, it's then possible to see their respective balances on the beacon chain explorer.
This returns the validators under a new
validatorsproperty for all staking entities (apart from pre-executed deposits).Changes
validatorsproperty to: