Return multiple of 32 for value of requestValidatorsExit
#1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorgomezv
approved these changes
Sep 26, 2024
DenSmolonski
pushed a commit
to Zilliqa/safe-client-gateway
that referenced
this pull request
Oct 24, 2024
…obal#1966) Adjusts the relevant value to return a multiple of 32, depending on the number of validators requesting exit: - Add `value` to `NativeStakingValidatorsExitTransactionInfo`. - Map `value` as multiple of 32 depending on validators. - Update tests accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
valueof a validator exit request is always a multiple of 32, the entry stake amount. This adjusts the relevant value to return a multiple of 32, depending on the number of validators requesting exit.Note: this also fixes the CI issue regarding milliseconds.
Changes
valuetoNativeStakingValidatorsExitTransactionInfo.valueas multiple of 32 depending on validators.