Add further relay chain configuration #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11069245516Details
💛 - Coveralls |
This was referenced Oct 2, 2024
hectorgomezv
approved these changes
Oct 8, 2024
.env.sample
Outdated
Comment on lines
55
to
65
| # RELAY_PROVIDER_API_KEY_OPTIMISM | ||
| # RELAY_PROVIDER_API_KEY_BSC | ||
| # RELAY_PROVIDER_API_KEY_GNOSIS_CHAIN | ||
| # RELAY_PROVIDER_API_KEY_POLYGON | ||
| # RELAY_PROVIDER_API_KEY_POLYGON_ZKEVM | ||
| # RELAY_PROVIDER_API_KEY_BASE | ||
| # RELAY_PROVIDER_API_KEY_ARBITRUM_ONE | ||
| # RELAY_PROVIDER_API_KEY_AVALANCHE | ||
| # RELAY_PROVIDER_API_KEY_LINEA | ||
| # RELAY_PROVIDER_API_KEY_BLAST | ||
| # RELAY_PROVIDER_API_KEY_SEPOLIA |
There was a problem hiding this comment.
Nit: I'd include the = at the end of each key to make explicit they need a value to be set.
There was a problem hiding this comment.
Nit: I'd suggest also including "" around strings to make it explicit which variables are numeric and which are strings.
PooyaRaki
approved these changes
Oct 8, 2024
.env.sample
Outdated
Comment on lines
55
to
65
| # RELAY_PROVIDER_API_KEY_OPTIMISM | ||
| # RELAY_PROVIDER_API_KEY_BSC | ||
| # RELAY_PROVIDER_API_KEY_GNOSIS_CHAIN | ||
| # RELAY_PROVIDER_API_KEY_POLYGON | ||
| # RELAY_PROVIDER_API_KEY_POLYGON_ZKEVM | ||
| # RELAY_PROVIDER_API_KEY_BASE | ||
| # RELAY_PROVIDER_API_KEY_ARBITRUM_ONE | ||
| # RELAY_PROVIDER_API_KEY_AVALANCHE | ||
| # RELAY_PROVIDER_API_KEY_LINEA | ||
| # RELAY_PROVIDER_API_KEY_BLAST | ||
| # RELAY_PROVIDER_API_KEY_SEPOLIA |
There was a problem hiding this comment.
Nit: I'd suggest also including "" around strings to make it explicit which variables are numeric and which are strings.
hectorgomezv
approved these changes
Oct 8, 2024
iamacook
added a commit
to safe-global/safe-infrastructure
that referenced
this pull request
Oct 8, 2024
Adds new sample env. vars. for [the extension of 'relayable' chains](safe-global/safe-client-gateway#1970): - Add env. vars. for: Optimism, BSC, Polygon, Polygon zkEVM, Base, Avalanche, Linea and Blast.
PooyaRaki
pushed a commit
that referenced
this pull request
Oct 15, 2024
Adds further configuration for: Optimism, BNB, Polygon, Polygon zkEVM, Base, Avalanche, Linea and Blast:
- Add env. var. configuration for aforementioned chains to:
- `.env.sample`
- `docker-compose.yaml`
- (Test) configuration
- Confirguration validator
- Test coverage
DenSmolonski
pushed a commit
to Zilliqa/safe-client-gateway
that referenced
this pull request
Oct 24, 2024
Adds further configuration for: Optimism, BNB, Polygon, Polygon zkEVM, Base, Avalanche, Linea and Blast:
- Add env. var. configuration for aforementioned chains to:
- `.env.sample`
- `docker-compose.yaml`
- (Test) configuration
- Confirguration validator
- Test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We currently support relaying on Gnosis Chain, Arbitrum and Sepolia. This adds further configuration for: Optimism, BNB, Polygon, Polygon zkEVM, Base, Avalanche, Linea and Blast.
Changes
.env.sampledocker-compose.yaml