Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unsupported chains aggregation logs #1978

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix unsupported chains aggregation logs #1978

merged 1 commit into from
Sep 30, 2024

Conversation

hectorgomezv
Copy link
Member

Changes

  • Fixes the unsupported chains events log aggregation by iterating over a dynamic array of the chain ids for the unsupported events received, instead of the configured chains.

@hectorgomezv hectorgomezv self-assigned this Sep 30, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner September 30, 2024 14:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11108047156

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 90.68%
Totals Coverage Status
Change from base Build 11107402959: 0.003%
Covered Lines: 8482
Relevant Lines: 8984
💛 - Coveralls

@hectorgomezv hectorgomezv merged commit ea22492 into main Sep 30, 2024
18 checks passed
@hectorgomezv hectorgomezv deleted the fix-bad-unsupported-chains-aggregation branch September 30, 2024 14:49
PooyaRaki pushed a commit that referenced this pull request Oct 15, 2024
@hectorgomezv @PooyaRaki
Fix unsupported chains aggregation logs (#1978)
fa5e6a7 
- Fix unsupported chains logs.
DenSmolonski pushed a commit to Zilliqa/safe-client-gateway that referenced this pull request Oct 24, 2024
@hectorgomezv @DenSmolonski
Fix unsupported chains aggregation logs (safe-global#1978)
76866a1 
- Fix unsupported chains logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamacook iamacook iamacook approved these changes

Assignees

@hectorgomezv hectorgomezv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hectorgomezv @coveralls @iamacook