Fix Swagger definitions #2008
Merged
Fix Swagger definitions #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PooyaRaki
pushed a commit
that referenced
this pull request
Oct 15, 2024
Fixes some issues in the Swagger schema: - All nullable values are defined in `ApiOptionalProperty` decorators, flagged as `nullable` with the correct `type` - All array-expected values leverage the `isArray` property instead of TypeScript annotations
DenSmolonski
pushed a commit
to Zilliqa/safe-client-gateway
that referenced
this pull request
Oct 24, 2024
Fixes some issues in the Swagger schema: - All nullable values are defined in `ApiOptionalProperty` decorators, flagged as `nullable` with the correct `type` - All array-expected values leverage the `isArray` property instead of TypeScript annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are observing inconsistencies between our TypeScript types and Swagger schema in our automatically generated SDK. This fixes some of those encountered issues.
Changes
ApiOptionalPropertydecorators, flagged asnullablewith the correcttypeisArrayproperty instead of TypeScript annotations