Add proposedByDelegate to multisig mapping
#2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is now on staging. |
hectorgomezv
approved these changes
Oct 25, 2024
Comment on lines
47
to
48
| .with('proposer', delegate) | ||
| .with('proposedByDelegate', delegate) |
There was a problem hiding this comment.
Nit: I think this wouldn't have any impact on the tests, but to make the instances generated by this builder more accurate: I think the proposer and the proposedByDelegate can't share the same address, right? Otherwise the transaction wouldn't be proposed by a delegate but by the owner themself and therefore proposedByDelegate would be null.
| @@ -246,4 +249,32 @@ describe('MultisigTransactionExecutionDetails mapper (Unit)', () => { | |||
| }), | |||
| ); | |||
| }); | |||
| it('should return a MultisigExecutionDetails object with no proposedByDelegate if not present', async () => { | |||
There was a problem hiding this comment.
Super nitpicky: missing newline just before this test case 🙂
hectorgomezv
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A new
proposedByDelegatefield has been added to multisig transactions on the Transaction Service. This is also needed by the client for delegate integration.This adds the new field to the relevant validation schema and maps it accordingly.
Changes