Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @nestjs/swagger from 7.4.2 to 8.0.0 #2073

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Bump @nestjs/swagger from 7.4.2 to 8.0.0 #2073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be09bf1
Bump @nestjs/swagger from 7.4.2 to 8.0.0
dependabot[bot] Oct 28, 2024
df0f326
FIx type
iamacook Oct 29, 2024
9cc3767
Merge branch 'main' into dependabot/npm_and_yarn/nestjs/swagger-8.0.0
iamacook Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@nestjs/platform-express": "^10.4.6",
"@nestjs/schedule": "^4.1.1",
"@nestjs/serve-static": "^4.0.2",
"@nestjs/swagger": "^7.4.2",
"@nestjs/swagger": "^8.0.0",
"@nestjs/typeorm": "^10.0.2",
"@safe-global/safe-deployments": "^1.37.13",
"amqp-connection-manager": "^4.1.14",
Expand Down
2 changes: 1 addition & 1 deletion src/routes/transactions/entities/swaps/twap-confirmation-view.entity.ts
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you briefly explain why this change is needed? Does the upgrade to a major version of Swagger introduce any breaking changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of the latest version, null types need to be defined as 'null'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any additional breaking changes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class CowSwapTwapConfirmationView implements Baseline, TwapOrderInfo {
description:
'The order UID of the active order, null as it is not an active order',
// Prevent bidirectional dependency
type: typeof null,
type: 'null',
})
activeOrderUid: null;

Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,9 +1875,9 @@ __metadata:
languageName: node
linkType: hard

"@nestjs/swagger@npm:^7.4.2":
version: 7.4.2
resolution: "@nestjs/swagger@npm:7.4.2"
"@nestjs/swagger@npm:^8.0.0":
version: 8.0.0
resolution: "@nestjs/swagger@npm:8.0.0"
dependencies:
"@microsoft/tsdoc": "npm:^0.15.0"
"@nestjs/mapped-types": "npm:2.0.5"
Expand All @@ -1899,7 +1899,7 @@ __metadata:
optional: true
class-validator:
optional: true
checksum: 10/e3f9cac6a092442461fe7e4edd45b8af3377a02c626bb2b9f7da2e0ffe4999c3c20f32240aa1a67e9999a919946e6ed6c0da01c703e7d83d49823f1d7b9caf09
checksum: 10/43294226fcccc0cde6377e2154845906868636788b76b6a7a4de25487bd6b75cd9b41fd642b3f2891185e314ccb13e6e1a1eeb656a48f758c6e7974018800e53
languageName: node
linkType: hard

Expand Down Expand Up @@ -8289,7 +8289,7 @@ __metadata:
"@nestjs/schedule": "npm:^4.1.1"
"@nestjs/schematics": "npm:^10.2.2"
"@nestjs/serve-static": "npm:^4.0.2"
"@nestjs/swagger": "npm:^7.4.2"
"@nestjs/swagger": "npm:^8.0.0"
"@nestjs/testing": "npm:^10.4.6"
"@nestjs/typeorm": "npm:^10.0.2"
"@safe-global/safe-deployments": "npm:^1.37.13"
Expand Down