Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map SafeApp['featured'] flag #2085

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Map SafeApp['featured'] flag #2085

merged 1 commit into from
Nov 4, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Nov 4, 2024

Summary

A featuredflag has been [added to theSafeApp` model](safe-global/safe-config-service#1272) of the Config Service.

This maps the new featured flag to the appropriate SafeApp entity, under the featured property.

Changes

  • Add featured to the SafeAppsSchema
  • Map flag to SafeApp['featured']
  • Update tests accordingly

@iamacook iamacook self-assigned this Nov 4, 2024
@iamacook iamacook requested a review from a team as a code owner November 4, 2024 12:00
hectorgomezv
hectorgomezv approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@hectorgomezv hectorgomezv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We have to recall the Config Service needs to be released/deployed before the CGW, otherwise this would make the Safe Apps retrieval fail.

@iamacook iamacook merged commit 2ffd3b4 into main Nov 4, 2024
20 checks passed
@iamacook iamacook deleted the feature-safe-apps branch November 4, 2024 12:22
@iamacook iamacook mentioned this pull request Nov 4, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorgomezv hectorgomezv hectorgomezv approved these changes

Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamacook @hectorgomezv