Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: types after API response upgrade #1112

Merged
merged 9 commits into from
Jan 29, 2025
Merged

fix: types after API response upgrade #1112

merged 9 commits into from
Jan 29, 2025

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Jan 28, 2025 •
edited
Loading

What it solves

Resolves #1083

Align types are with API response upgrade.

@dasanra dasanra requested a review from DaniSomoza January 28, 2025 12:35
@dasanra dasanra force-pushed the migrate-nonce-type branch from bf2751c to 6a62152 Compare January 28, 2025 12:45
@dasanra dasanra force-pushed the migrate-nonce-type branch from 4b60a04 to b553ebf Compare January 29, 2025 09:00
@dasanra dasanra changed the title fix: keep types unchanged after API response upgrade fix: types after API response upgrade Jan 29, 2025
@coveralls
Copy link

coveralls commented Jan 29, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13030967466

Details

  • 4 of 9 (44.44%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 74.773%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/api-kit/src/SafeApiKit.ts 3 8 37.5%
Totals Coverage Status
Change from base Build 12986758611: -0.2%
Covered Lines: 800
Relevant Lines: 992
💛 - Coveralls

@dasanra dasanra merged commit 9c4e5cd into development Jan 29, 2025
22 checks passed
@dasanra dasanra deleted the migrate-nonce-type branch January 29, 2025 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
@dasanra dasanra linked an issue Jan 31, 2025 that may be closed by this pull request
Update 4337 SafeOperationResponse types to match backend changes #1083
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DaniSomoza DaniSomoza DaniSomoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update 4337 SafeOperationResponse types to match backend changes
3 participants
@dasanra @coveralls @DaniSomoza