Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-kit): Fix signature generation for multiple contract signatures #1114

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sidnym-ladrut
Copy link

What it solves

There are currently a few minor issues in protocol-kit related to contract signatures (i.e. EIP-1271):

  1. Contract signatures processed by the API are not recognized as such (fix in Safe.ts).
  2. The dynamic part of a contract signature is calculated as the entire segment of the given data, when it should be the last 97 bytes only (65 bytes signature + 32 bytes length).

How this PR fixes it

These issues are fixed in the following ways:

  1. All CONTRACT_SIGNATURE responses are registered as contract signatures.
  2. The dynamic part of contract signatures is adjusted to be the last 97 bytes of the data payload.

Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant