Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Switch v1.4.1 to released #248

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Feature: Switch v1.4.1 to released #248

merged 1 commit into from
Jul 6, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jun 28, 2023

This PR:

  • Switches the released flag for 1.4.1 to true
  • Adjusts tests that checked that the latest returned version was 1.3.0

@mmv08 mmv08 requested review from a team as code owners June 28, 2023 11:25
rmeissner
rmeissner approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@rmeissner rmeissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What impact does this have on the interface that use this (i.e. Safe Wallet)? Would they start creating Safes with the new version?

@mmv08
Copy link
Member Author

mmv08 commented Jun 30, 2023

@rmeissner:

We have a global constant (set to 1.3.0) that we filter by. However, some places just filter by network. We could ensure everywhere relevant uses the constant and/or the released flag though.

That's their latest update from 3 months ago. I will double check with the web team before releasing

@mmv08 mmv08 mentioned this pull request Jun 30, 2023
Closed
@mmv08 mmv08 merged commit e0dd976 into main Jul 6, 2023
@mmv08 mmv08 deleted the feat/1.4.1-released branch July 6, 2023 09:13
@katspaugh katspaugh mentioned this pull request Aug 24, 2023
Merged
@katspaugh
Copy link
Member

This is definitely a breaking change for us. Should have been a major version, not a patch version. I've fixed it in the linked PR for multisends. Need to check other contracts too.

@mmv08 mmv08 mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmeissner rmeissner rmeissner approved these changes

@Uxio0 Uxio0 Awaiting requested review from Uxio0 Uxio0 is a code owner automatically assigned from safe-global/safe-protocol

@akshay-ap akshay-ap Awaiting requested review from akshay-ap akshay-ap is a code owner automatically assigned from safe-global/safe-protocol

@moisses89 moisses89 Awaiting requested review from moisses89 moisses89 was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmv08 @katspaugh @rmeissner