Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new networks and clients #662

Merged
merged 12 commits into from
Nov 14, 2023
Merged

feat: add new networks and clients #662

merged 12 commits into from
Nov 14, 2023

Conversation

nick8319
Copy link
Contributor

@nick8319 nick8319 commented Oct 16, 2023 •
edited
Loading

Pull request contains:

  • Master Copies and Proxy Factories for 2 networks(feat: add Scroll Mainnet and Zetachain Athens Testnet safe-deployments#304):

    • ZETACHAIN_ATHENS_TESTNET
    • SCROLL

  • addition of Blockscout clients for:

    • SHIDEN
    • SCROLL
    • SCROLL_SEPOLIA_TESTNET
    • ZETACHAIN_ATHENS_TESTNET
    • RSK_MAINNET
    • RSK_TESTNET
    • LINEA
    • LINEA_TESTNET
    • NEON_EVM_MAINNET
    • NEON_EVM_DEVNET
    • OASIS_SAPPHIRE
    • OASIS_SAPPHIRE_TESTNET
    • CASCADIA_TESTNET
    • TENET
    • TENET_TESTNET
    • VELAS_EVM_MAINNET
    • CRONOS_MAINNET_BETA
    • CRONOS_TESTNET
    • THUNDERCORE_MAINNET
    • THUNDERCORE_TESTNET

  • addition of Etherscan clients for:

    • SCROLL
    • SCROLL_SEPOLIA_TESTNET

@nick8319 nick8319 requested a review from a team as a code owner October 16, 2023 09:59
@nick8319 nick8319 requested review from fmrsabino, Uxio0 and hectorgomezv and removed request for a team October 16, 2023 09:59
@nick8319 nick8319 changed the title feat: add Scroll Mainnet and Zetachain Athens Testnet feat: add new networks and clients Oct 17, 2023
@ElvisKrop
Copy link
Contributor

Hello guys! Please take a look at this PR whenever you can 🙏
@Uxio0 @fmrsabino @hectorgomezv
We decided to open this single PR which includes tiny updates for quite many networks, in order not to spam you by opening separate PRs for each of them. Especially considering that merging each separate PR will lead to conflicts in all other similar PRs 🙃
Thanks in advance!

@Uxio0
Copy link
Member

Uxio0 commented Oct 18, 2023

Please let us know when safe-deployments related PRs are merged, but taking a look I see that for some networks you are not using the official expected addreses using the Safe singleton factory deployer

moisses89
moisses89 reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a heavy request but if the block is wrongly configured you can lose Safes if there were any Safe created previously to that block.

gnosis/safe/addresses.py
@@ -595,6 +595,14 @@
("0x3E5c63644E683549055b9Be8653de26E0B4CD36E", 2362236, "1.3.0+L2"),
("0xd9Db270c1B5E3Bd161E8c8503c55cEABeE709552", 2362238, "1.3.0"),
],
EthereumNetwork.ZETACHAIN_ATHENS_TESTNET: [
("0xfb1bffC9d739B8D520DaF37dF666da4C687191EA", 1962980, "1.3.0+L2"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nick8319 I couldn't verify the deploy block using the blockexplorer https://zetachain-athens-3.blockscout.com/address/0xfb1bffC9d739B8D520DaF37dF666da4C687191EA
How do you get this block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @moisses89, unfortunately Blockscout doesn't index internal transactions on Zetachain Testnet that's why it doesn't recognize safe-contracts as contracts. But I have transaction hashes saved during safe-contracts deployment. Here they are:
GnosisSafe: https://zetachain-athens-3.blockscout.com/tx/0x614a1428afd37470db6836abe53f191b3cc4470fd08212e0b3706166fcc24b44?tab=index
GnosisSafeL2: https://zetachain-athens-3.blockscout.com/tx/0x2934f55bae338f3af78fd2f86d98b42fd82f517feb9008b99837aaa4237b66e2?tab=index
GnosisSafeProxyFactory: https://zetachain-athens-3.blockscout.com/tx/0xfc3ba1aea3dd297d63172c4429bc59a47f6ddb0a1525ac156a6e83b8d6734cb9?tab=index

@moisses89 moisses89 merged commit a1ffc5f into safe-global:master Nov 14, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
@ElvisKrop ElvisKrop deleted the add_Zetachain_Scroll branch February 21, 2024 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

@fmrsabino fmrsabino Awaiting requested review from fmrsabino fmrsabino was automatically assigned from safe-global/safe-services

@Uxio0 Uxio0 Awaiting requested review from Uxio0 Uxio0 was automatically assigned from safe-global/safe-services

@hectorgomezv hectorgomezv Awaiting requested review from hectorgomezv hectorgomezv was automatically assigned from safe-global/safe-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nick8319 @ElvisKrop @Uxio0 @moisses89